Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace SDKs catch (Exception e) to catch (Throwable e) #1806

Closed
marandaneto opened this issue Nov 15, 2021 · 3 comments
Closed

Replace SDKs catch (Exception e) to catch (Throwable e) #1806

marandaneto opened this issue Nov 15, 2021 · 3 comments

Comments

@marandaneto
Copy link
Contributor

SDK should not crash the finals App, but rather swallow and log it.
this would avoid issues such as #1800

Context: #1800 (comment)

@philipphofmann
Copy link
Member

Make sure to log out when we swallow a Throwable. We still need to find out how to log out.

@bruno-garcia
Copy link
Member

bruno-garcia commented Nov 18, 2021

The PR #1812 partially addresses this. See PR description for details.
Goal: Changes all Java catch Exception to Throwable so we avoid crashes on Unity that should have been suppressed.

For this issue I suggest we add a linter. So we avoid adding catch Exception again in the future. The linter should warn that throwable should be used to suppress all errors instead.

@romtsn
Copy link
Member

romtsn commented Oct 18, 2023

Added an additional point to #2685 to track the lint checks, closing this one

@romtsn romtsn closed this as completed Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

5 participants