Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attachments and SentryEnvelopeItemHeader should support the 'attachmentType' field #1257

Closed
marandaneto opened this issue Feb 16, 2021 · 1 comment
Closed

Attachments and SentryEnvelopeItemHeader should support the 'attachmentType' field #1257

marandaneto opened this issue Feb 16, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@marandaneto
Copy link
Contributor

Right now attachments and envelope item headers only use the default value inferred by the backend, https://develop.sentry.dev/sdk/envelopes/#attachment which is event.attachment, but if an envelope is written by 3rd party SDKs like Flutter/RN/Sentry-native that uses a different type, it does not work.

Eg #1256

We'd need to support this field to not be lost during serialization/deserialization.

cc @philipphofmann
@marandaneto marandaneto added the enhancement New feature or request label Feb 16, 2021
@dependabot dependabot bot mentioned this issue Mar 14, 2021
Closed
@marandaneto
Copy link
Contributor Author

Done by #1504

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
Mobile & Cross Platform SDK
Archived in project
Milestone
No milestone
Development

No branches or pull requests
1 participant
@marandaneto