-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(node): Update and vendor https-proxy-agent
#10088
Merged
AbhiPrasad
merged 7 commits into
getsentry:develop
from
timfish:feat/vendor-http-proxy-agent
Jan 18, 2024
Merged
feat(node): Update and vendor https-proxy-agent
#10088
AbhiPrasad
merged 7 commits into
getsentry:develop
from
timfish:feat/vendor-http-proxy-agent
Jan 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Once #10156 is merged, we can test this! |
This is now tested via a previously added integration test! |
AbhiPrasad
approved these changes
Jan 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Going to update this branch so we can get it out with the next release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9199
This PR vendors the
https-proxy-agent
code and in the process updates to v7.0.0.https-proxy-agent
is our last remaining cjs-only dependency so this is required for #10046.This removes the following dependencies:
https-proxy-agent@5.0.1
agent-base@6.0.2
debug@4.3.4
ms@2.1.2
The vendored code has been modified to use the Sentry logger rather than
debug
.Initially, rather than modify the vendored code substantially just to pass our tight lint rules, I've disabled a few of the less important lints that would make it particularly tricky to pull in upstream bug fixes:
Min supported Node version
https-proxy-agent
has a@types/node@14.18.45
dev dependency but apart from adding an import forURL
, I can't find anything that would stop it working on older versions of node and there is nothing in the changelogs that would suggest the min supported version has changed.