feat(replay): Add ReplayCanvas integration
#10112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
|
@mydea works if it's in a sep package, but still need to test that canvas recording still works (though the e2e test should confirm this) |
hmm wtf, but well, good :D if that fixes it, amazing! |
|
@mydea a few questions:
|
billyvg
added a commit
to getsentry/rrweb
that referenced
this pull request
Jan 9, 2024
This simplifies the code a bit by exporting the CanvasManager directly. With [ReplayCanvas](getsentry/sentry-javascript#10112), we can rely on it for complex setup, but keeps it simple for our users.
billyvg
added a commit
to getsentry/rrweb
that referenced
this pull request
Jan 9, 2024
This simplifies the code a bit by exporting the CanvasManager directly. With [ReplayCanvas](getsentry/sentry-javascript#10112), we can rely on it for complex setup, but keeps it simple for our users.
billyvg
commented
Jan 9, 2024
billyvg
added a commit
to getsentry/rrweb
that referenced
this pull request
Jan 9, 2024
This simplifies the code a bit by exporting the CanvasManager directly. With [ReplayCanvas](getsentry/sentry-javascript#10112), we can rely on it for complex setup, but keeps it simple for our users.
billyvg
added a commit
to getsentry/rrweb
that referenced
this pull request
Jan 9, 2024
This simplifies the code a bit by exporting the CanvasManager directly. With [ReplayCanvas](getsentry/sentry-javascript#10112), we can rely on it for complex setup, but keeps it simple for our users.
mydea
reviewed
Jan 10, 2024
| @@ -32,6 +32,10 @@ targets: | |||
| - name: npm | |||
| id: '@sentry-internal/feedback' | |||
| includeNames: /^sentry-internal-feedback-\d.*\.tgz$/ | |||
| ## 1.8 ReplayCanvas package (browser only) | |||
There was a problem hiding this comment.
Do we need to publish this? Or could we just inline this into browser/replay, same as we do with e.g. replay-worker? IMHO if we can avoid to publish it, we should!
There was a problem hiding this comment.
@mydea I added this back, it's been a pain trying to test this package without it being published. e.g. in my test app, I'll use yalc to add @sentry/browser @sentry/replay, but yarn will complain:
error Couldn't find package "@sentry-internal/replay-canvas@7.93.0" required by "@sentry/browser@file:.yalc/@sentry/browser" on the "npm" registry.
mydea
reviewed
Jan 10, 2024
mydea
reviewed
Jan 10, 2024
packages/browser-integration-tests/suites/replay/canvas/template.html
Outdated
Show resolved
Hide resolved
mydea
reviewed
Jan 10, 2024
mydea
reviewed
Jan 10, 2024
mydea
reviewed
Jan 10, 2024
mydea
reviewed
Jan 10, 2024
mydea
reviewed
Jan 10, 2024
billyvg
force-pushed
the
fn/replay-canvas-integration-sep-package
branch
2 times, most recently
from
3e11d66
to
86ce591
Compare
billyvg
added a commit
to getsentry/rrweb
that referenced
this pull request
Jan 10, 2024
#153) This simplifies the code a bit by exporting the CanvasManager directly. With [ReplayCanvas](getsentry/sentry-javascript#10112), we can rely on it for complex setup, but keeps it simple for our users.
billyvg
force-pushed
the
fn/replay-canvas-integration-sep-package
branch
3 times, most recently
from
b39c5fe
to
d001529
Compare
billyvg
force-pushed
the
fn/replay-canvas-integration-sep-package
branch
from
9dd8cfe
to
b87f421
Compare
This reverts commit f3290c4.
billyvg
added a commit
to getsentry/rrweb
that referenced
this pull request
Apr 26, 2024
#153) This simplifies the code a bit by exporting the CanvasManager directly. With [ReplayCanvas](getsentry/sentry-javascript#10112), we can rely on it for complex setup, but keeps it simple for our users.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding this integration in addition to
Replaywill set up canvas recording.