Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): Deprecate Span.isSuccess() in favor of reading span status #10213

Merged
merged 1 commit into from
Jan 17, 2024

Conversation

Lms24
Copy link
Member

@Lms24 Lms24 commented Jan 17, 2024

This PR deprecates Span.isSuccess() in favor of directly reading the span status via spanToJSON(span).status === 'ok' instead. There's no need for this API as it's just syntactic sugar around the status.

Seemed like we didn't even use this API in our SDKs - maybe some downstream SDKs use it but migrating should be very straightforward.

ref #10184

@Lms24 Lms24 changed the title feat(core): Deprecate Span.isSuccess in favor of reading span status feat(core): Deprecate Span.isSuccess() in favor of reading span status Jan 17, 2024
@Lms24 Lms24 self-assigned this Jan 17, 2024
@Lms24 Lms24 force-pushed the lms/feat-core-deprecate-span-isSuccess branch from 15d55ad to 172fa2a Compare January 17, 2024 11:51
Copy link
Contributor

github-actions bot commented Jan 17, 2024

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay, Feedback) - Webpack (gzipped) 77.35 KB (added)
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 68.66 KB (added)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped) 62.3 KB (added)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 32.67 KB (added)
@sentry/browser (incl. Feedback) - Webpack (gzipped) 31.13 KB (added)
@sentry/browser - Webpack (gzipped) 22.48 KB (added)
@sentry/browser (incl. Tracing, Replay, Feedback) - ES6 CDN Bundle (gzipped) 75.01 KB (added)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 66.65 KB (added)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 32.48 KB (added)
@sentry/browser - ES6 CDN Bundle (gzipped) 24.19 KB (added)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 209.83 KB (added)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 97.89 KB (added)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 72.34 KB (added)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 35.49 KB (added)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 69.04 KB (added)
@sentry/react - Webpack (gzipped) 22.52 KB (added)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 85.66 KB (added)
@sentry/nextjs Client - Webpack (gzipped) 49.81 KB (added)
@sentry-internal/feedback - Webpack (gzipped) 17.11 KB (added)

@Lms24 Lms24 force-pushed the lms/feat-core-deprecate-span-isSuccess branch from 172fa2a to 0af1aeb Compare January 17, 2024 14:10
@Lms24 Lms24 merged commit f9ed885 into develop Jan 17, 2024
96 checks passed
@Lms24 Lms24 deleted the lms/feat-core-deprecate-span-isSuccess branch January 17, 2024 17:16
AbhiPrasad added a commit that referenced this pull request Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants