-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(tracing): Ensure web vitals are correctly stopped/captured #10323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 馃摝
|
AbhiPrasad
approved these changes
Jan 24, 2024
edwardgou-sentry
approved these changes
Jan 24, 2024
Seems like we have the LCP playwright tests failing? |
mydea
force-pushed
the
fn/browser-metrics
branch
from
January 24, 2024 20:05
86dc8b6
to
789d70c
Compare
I pushed a commit hopefully fixing the test, let's see.. hard to debug these things! Worst case we can remove the last part of the test for now, I think it's OK either way! |
mydea
force-pushed
the
fn/browser-metrics
branch
from
January 24, 2024 20:46
65deb88
to
85dfad1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was identified as a problem by @edwardgou-sentry , and was incorrectly changed in 7.75.0.
I think this should work now as expected 馃 I added some tests for LCP to hopefully very this works kind of as expected (=even after stopping it you can still get a LCP value).