Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tracing): Ensure web vitals are correctly stopped/captured #10323

Merged
merged 5 commits into from
Jan 24, 2024

Conversation

mydea
Copy link
Member

@mydea mydea commented Jan 24, 2024

This was identified as a problem by @edwardgou-sentry , and was incorrectly changed in 7.75.0.

I think this should work now as expected 馃 I added some tests for LCP to hopefully very this works kind of as expected (=even after stopping it you can still get a LCP value).

@mydea mydea self-assigned this Jan 24, 2024
Copy link
Contributor

github-actions bot commented Jan 24, 2024

size-limit report 馃摝

Path Size
@sentry/browser (incl. Tracing, Replay, Feedback) - Webpack (gzipped) 77.84 KB (-0.01% 馃斀)
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 69.04 KB (+0.03% 馃敽)
@sentry/browser (incl. Tracing, Replay with Canvas) - Webpack (gzipped) 72.93 KB (+0.01% 馃敽)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped) 62.68 KB (+0.05% 馃敽)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 33.06 KB (+0.08% 馃敽)
@sentry/browser (incl. Feedback) - Webpack (gzipped) 31.25 KB (0%)
@sentry/browser (incl. sendFeedback) - Webpack (gzipped) 31.26 KB (0%)
@sentry/browser - Webpack (gzipped) 22.5 KB (0%)
@sentry/browser (incl. Tracing, Replay, Feedback) - ES6 CDN Bundle (gzipped) 75.57 KB (-0.05% 馃斀)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 67.13 KB (-0.06% 馃斀)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 32.97 KB (-0.08% 馃斀)
@sentry/browser - ES6 CDN Bundle (gzipped) 24.43 KB (-0.06% 馃斀)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 211.42 KB (-0.1% 馃斀)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 99.44 KB (-0.17% 馃斀)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 73.08 KB (-0.08% 馃斀)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 36.07 KB (-0.09% 馃斀)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 69.45 KB (-0.01% 馃斀)
@sentry/react - Webpack (gzipped) 22.55 KB (0%)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 86.11 KB (+0.02% 馃敽)
@sentry/nextjs Client - Webpack (gzipped) 50.4 KB (+0.03% 馃敽)
@sentry-internal/feedback - Webpack (gzipped) 17.21 KB (0%)

@AbhiPrasad
Copy link
Member

Seems like we have the LCP playwright tests failing?

@mydea
Copy link
Member Author

mydea commented Jan 24, 2024

Seems like we have the LCP playwright tests failing?

I pushed a commit hopefully fixing the test, let's see.. hard to debug these things! Worst case we can remove the last part of the test for now, I think it's OK either way!

@mydea mydea merged commit b72a681 into develop Jan 24, 2024
93 checks passed
@mydea mydea deleted the fn/browser-metrics branch January 24, 2024 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants