Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bun): Add missing @sentry/node re-exports #10396

Merged
merged 3 commits into from Jan 30, 2024

Conversation

Lms24
Copy link
Member

@Lms24 Lms24 commented Jan 29, 2024

This PR adds missing exports from the Node to the Bun SDK. Ignored a couple of exports that I believe aren't compatible with Bun or for which we have dedicated Bun repalcements (e.g. client, transport).

Node would throw ESM/CJS errors when importing from @sentry/bun. So let's just use Bun for this test 馃檭

more details in #10389

Copy link
Contributor

size-limit report 馃摝

Path Size
@sentry/browser (incl. Tracing, Replay, Feedback) - Webpack (gzipped) 78.1 KB (-0.05% 馃斀)
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 69.32 KB (-0.04% 馃斀)
@sentry/browser (incl. Tracing, Replay with Canvas) - Webpack (gzipped) 73.2 KB (-0.06% 馃斀)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped) 62.94 KB (-0.05% 馃斀)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 33.34 KB (-0.13% 馃斀)
@sentry/browser (incl. browserTracingIntegration) - Webpack (gzipped) 33.23 KB (-0.14% 馃斀)
@sentry/browser (incl. Feedback) - Webpack (gzipped) 31.33 KB (+0.01% 馃敽)
@sentry/browser (incl. sendFeedback) - Webpack (gzipped) 31.34 KB (+0.01% 馃敽)
@sentry/browser - Webpack (gzipped) 22.6 KB (-0.02% 馃斀)
@sentry/browser (incl. Tracing, Replay, Feedback) - ES6 CDN Bundle (gzipped) 75.88 KB (-0.1% 馃斀)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 67.44 KB (-0.09% 馃斀)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 33.32 KB (-0.15% 馃斀)
@sentry/browser - ES6 CDN Bundle (gzipped) 24.51 KB (-0.03% 馃斀)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 212.52 KB (-0.02% 馃斀)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 100.53 KB (-0.04% 馃斀)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 73.44 KB (+0.13% 馃敽)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 36.4 KB (-0.18% 馃斀)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 69.71 KB (-0.08% 馃斀)
@sentry/react - Webpack (gzipped) 22.63 KB (-0.02% 馃斀)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 86.38 KB (-0.05% 馃斀)
@sentry/nextjs Client - Webpack (gzipped) 50.69 KB (-0.08% 馃斀)
@sentry-internal/feedback - Webpack (gzipped) 17.21 KB (-0.04% 馃斀)

@Lms24 Lms24 marked this pull request as ready for review January 29, 2024 16:28
@Lms24 Lms24 merged commit 18c0a4f into develop Jan 30, 2024
94 checks passed
@Lms24 Lms24 deleted the lms/feat-bun-add-missing-node-exports branch January 30, 2024 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants