Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(react): Add reactRouterV3BrowserTracingIntegration for react router v3 #10489

Merged
merged 3 commits into from Feb 5, 2024

Conversation

mydea
Copy link
Member

@mydea mydea commented Feb 5, 2024

To replace the routing instrumentation.

There is a small issue here, which is that we do not set the from attribute for the first navigation after the pageload (as technically we are calling instrument twice there...) - IMHO that's acceptable, we don't really have a from field anyhow in other instrumentations, so we may even think about removing this I'd say...

@mydea mydea self-assigned this Feb 5, 2024
@mydea mydea changed the title feat(react): Add browserTracingReactRouterV3Integration feat(react): Add browserTracingReactRouterV3Integration for react router v3 Feb 5, 2024
export {
// eslint-disable-next-line deprecation/deprecation
reactRouterV3Instrumentation,
browserTracingReactRouterV3Integration,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as in #10488, reactRouterV3BrowserTracingIntegration would sound a bit cleaner to me.

@mydea mydea changed the title feat(react): Add browserTracingReactRouterV3Integration for react router v3 feat(react): Add reactRouterV3BrowserTracingIntegration for react router v3 Feb 5, 2024
Copy link
Member

@AbhiPrasad AbhiPrasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO that's acceptable, we don't really have a from field anyhow in other instrumentations, so we may even think about removing this I'd say

Let's remove

Copy link
Contributor

github-actions bot commented Feb 5, 2024

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay, Feedback) - Webpack (gzipped) 78.4 KB (+0.09% 🔺)
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 69.63 KB (+0.1% 🔺)
@sentry/browser (incl. Tracing, Replay with Canvas) - Webpack (gzipped) 73.57 KB (+0.11% 🔺)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped) 63.25 KB (+0.12% 🔺)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 33.59 KB (+0.22% 🔺)
@sentry/browser (incl. browserTracingIntegration) - Webpack (gzipped) 33.46 KB (+0.23% 🔺)
@sentry/browser (incl. Feedback) - Webpack (gzipped) 31.37 KB (0%)
@sentry/browser (incl. sendFeedback) - Webpack (gzipped) 31.37 KB (0%)
@sentry/browser - Webpack (gzipped) 22.64 KB (0%)
@sentry/browser (incl. Tracing, Replay, Feedback) - ES6 CDN Bundle (gzipped) 76.61 KB (+0.34% 🔺)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 68.11 KB (+0.32% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 33.91 KB (+0.74% 🔺)
@sentry/browser - ES6 CDN Bundle (gzipped) 24.92 KB (+0.77% 🔺)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 214.61 KB (+0.26% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 102.42 KB (+0.55% 🔺)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 74.69 KB (+0.59% 🔺)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 37.05 KB (+0.71% 🔺)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 70 KB (+0.11% 🔺)
@sentry/react - Webpack (gzipped) 22.67 KB (0%)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 87.62 KB (+0.09% 🔺)
@sentry/nextjs Client - Webpack (gzipped) 51.82 KB (+0.18% 🔺)
@sentry-internal/feedback - Webpack (gzipped) 17.21 KB (0%)

@mydea mydea merged commit 2227b27 into develop Feb 5, 2024
43 checks passed
@mydea mydea deleted the fn/react-router-v3 branch February 5, 2024 16:54
mydea added a commit that referenced this pull request Feb 6, 2024
There is a proper replacement for all of them now.

Depends on:

* #10491
* #10489
* #10488
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants