Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

meta: Backport fixes to v7 #10759

Merged
merged 2 commits into from
Feb 21, 2024
Merged

meta: Backport fixes to v7 #10759

merged 2 commits into from
Feb 21, 2024

Conversation

mydea
Copy link
Member

@mydea mydea commented Feb 21, 2024

This includes two fixes that should be backported:

@mydea
ref: Make span types more robust (#10660)
01f6386 
With more strict TS settings, these could lead to problems:

1. `startChild()` should return a span interface, to match the interface
implementation.
2. All properties that are optional in span/transactions need to also
accept `| undefined` to be really correct - otherwise when we extend
this and set `undefined` explicitly it complains there.

Fixes #10654
@mydea
fix(tracing): Guard against missing window.location (#10659)
f40cba0 
We should also backport this to v7, probably.

Closes #10578
@mydea mydea requested review from lforst and Lms24 February 21, 2024 08:14
@mydea mydea self-assigned this Feb 21, 2024
@github-actions GitHub Actions
Copy link
Contributor

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay, Feedback) - Webpack (gzipped) 78.43 KB (0%)
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 69.66 KB (0%)
@sentry/browser (incl. Tracing, Replay with Canvas) - Webpack (gzipped) 73.6 KB (0%)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped) 63.28 KB (0%)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 33.62 KB (0%)
@sentry/browser (incl. browserTracingIntegration) - Webpack (gzipped) 33.51 KB (+0.03% 🔺)
@sentry/browser (incl. Feedback) - Webpack (gzipped) 31.38 KB (0%)
@sentry/browser (incl. sendFeedback) - Webpack (gzipped) 31.39 KB (0%)
@sentry/browser - Webpack (gzipped) 22.66 KB (-0.01% 🔽)
@sentry/browser (incl. Tracing, Replay, Feedback) - ES6 CDN Bundle (gzipped) 76.72 KB (0%)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 68.21 KB (0%)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 34.03 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped) 25.05 KB (+0.01% 🔺)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 214.99 KB (0%)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 102.78 KB (0%)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 75.08 KB (0%)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 37.19 KB (0%)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 70.03 KB (0%)
@sentry/react - Webpack (gzipped) 22.69 KB (0%)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 87.71 KB (+0.02% 🔺)
@sentry/nextjs Client - Webpack (gzipped) 51.9 KB (+0.03% 🔺)
@sentry-internal/feedback - Webpack (gzipped) 17.24 KB (0%)

@mydea mydea merged commit 4de88db into v7 Feb 21, 2024
100 checks passed
@mydea mydea deleted the fn/backport-fixes branch February 21, 2024 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lms24 Lms24 Lms24 approved these changes

@lforst lforst Awaiting requested review from lforst

Assignees

@mydea mydea

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mydea @Lms24