Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(ember): Avoid namespace import to hopefully resolve minification issue #10885

Merged
merged 1 commit into from Mar 1, 2024

Conversation

mydea
Copy link
Member

@mydea mydea commented Mar 1, 2024

Let's see if this actually fixes this issue: #10566 🤔 Maybe the internal bundler is thrown off by the fact that we lazy load browser tracing further below, and only includes certain things in Sentry on top, not sure...

…issue

Not sure if this will change stuff, but maybe this is tree shaken away incorrectly there, for whatever reason... let's try to see if this helps with things!
@mydea mydea requested review from AbhiPrasad and s1gr1d March 1, 2024 10:33
@mydea mydea self-assigned this Mar 1, 2024
Copy link
Member

@s1gr1d s1gr1d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's hope this fixes the issue! 👍🏻

@mydea mydea merged commit 4b7deee into develop Mar 1, 2024
59 checks passed
@mydea mydea deleted the fn/ember-imports branch March 1, 2024 10:46
@AbhiPrasad AbhiPrasad mentioned this pull request Mar 1, 2024
AbhiPrasad pushed a commit that referenced this pull request Mar 7, 2024
…issue (#10885)

Let's see if this actually fixes this issue:
#10566 🤔 Maybe the
internal bundler is thrown off by the fact that we lazy load browser
tracing further below, and only includes certain things in `Sentry` on
top, not sure...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants