Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(sveltekit): Fix punctuation in a console.log #10895

Merged
merged 1 commit into from Mar 4, 2024

Conversation

bfontaine
Copy link
Contributor

Before submitting a pull request, please take a look at our
Contributing guidelines and verify:

  • If you've added code that should be tested, please add tests.
  • Ensure your code lints and the test suite passes (yarn lint) & (yarn test).

Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx!

@Lms24 Lms24 changed the title SvelteKit source maps: fix punctuation in a console.log chore(sveltekit): Fix punctuation in a console.log Mar 3, 2024
@mydea mydea changed the base branch from master to develop March 4, 2024 08:04
@mydea
Copy link
Member

mydea commented Mar 4, 2024

Hey, I changed the PR target from master to develop (we merge every PR into develop, master is the released state), but that seemed to pick up some commits from master as well - could you drop them from this PR, so only the typo fix remains? Thank you!

@bfontaine
Copy link
Contributor Author

Done!

Copy link
Member

@AbhiPrasad AbhiPrasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@AbhiPrasad AbhiPrasad merged commit 9ababfd into getsentry:develop Mar 4, 2024
35 checks passed
@bfontaine bfontaine deleted the patch-1 branch March 4, 2024 16:51
@AbhiPrasad
Copy link
Member

Released this with https://github.com/getsentry/sentry-javascript/releases/tag/7.106.0 - thanks for the PR @bfontaine!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants