Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raven interferes with ckeditor5 #1104

Closed
jleider opened this issue Oct 25, 2017 · 8 comments
Closed

Raven interferes with ckeditor5 #1104

jleider opened this issue Oct 25, 2017 · 8 comments

Comments

@jleider
Copy link

jleider commented Oct 25, 2017

Adding raven-js to a page with ckeditor5 causes a TypeError: emitter.on is not a function error from ckeditor5 during initialization. There is a more detailed account of this same thing happening with zone.js: ckeditor/ckeditor5#413 the issue stemmed from altering native prototypes: ckeditor/ckeditor5#413 (comment)

This has been reproduced with raven-js 3.15.0 and 3.19.1.

Browser: Chrome 61, Mac OS

@davidpolberger
Copy link

For what it's worth, this is affecting us too. Our interim solution is to call Raven._restoreBuiltIns(). As a result, we no longer have access to breadcrumbs in the reports, but at least CKEditor 5 works well.

@kamilogorek
Copy link
Contributor

I'll look into this

@kamilogorek
Copy link
Contributor

Fixed in #1106
@jleider @davidpolberger would love to get a confirmation that it works with your setup using updated commit in package.json

"raven-js": "getsentry/raven-js#cf89f867b0834c1e5f8c146714549db7e2078577"

@davidpolberger
Copy link

cf89f86 works great, @kamilogorek, thanks! (For anyone following this thread, you need to build a package manually using npm install and grunt build.)

@kamilogorek
Copy link
Contributor

Thanks @davidpolberger! I'll release new version soon.

@thedavidmeister
Copy link

i ran into this over here https://github.com/ckeditor/ckeditor5-editor-balloon/issues/12

looks like raven 3.20.1 doesn't have this error in it

@kamilogorek
Copy link
Contributor

Thanks for reporting that @thedavidmeister!

@thedavidmeister
Copy link

looks like google closure advanced optimisations might be re-triggering this issue, see linked ^^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants