Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Colons (:) in HTML class names can cause Replay player to not apply the CSS #11086

Closed
billyvg opened this issue Mar 13, 2024 · 4 comments
Closed
Labels
Package: replay Issues related to the Sentry Replay SDK

Comments

@billyvg
Copy link
Member

billyvg commented Mar 13, 2024

See https://github.com/getsentry/team-replay/issues/398 for more information

Possibly related to getsentry/rrweb#86

@billyvg billyvg added the Package: replay Issues related to the Sentry Replay SDK label Mar 13, 2024
@rodolfoBee
Copy link
Member

@billyvg the affected user is asking for an update, can you provide one or an ETA for when it will be updated/fixed?

@billyvg
Copy link
Member Author

billyvg commented Mar 20, 2024

@rodolfoBee No ETA yet, we're still working on creating a repro of the problem in a sandbox so that we can work on a fix.

@billyvg
Copy link
Member Author

billyvg commented Mar 21, 2024

The issue is here -- this regex will incorrectly split a functional pseudo-class selector that has multiple arguments, e.g. :has(.foo, .bar) { will be split into 2 selectors: :has(.foo and .bar).

@rodolfoBee
Copy link
Member

This issue should now be fixed, please add a comment if still experiencing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Package: replay Issues related to the Sentry Replay SDK
Projects
Archived in project
Development

No branches or pull requests

2 participants