Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(node): Add scope to ANR events (v7) #11267

Merged
merged 7 commits into from Mar 28, 2024
Merged

feat(node): Add scope to ANR events (v7) #11267

merged 7 commits into from Mar 28, 2024

Conversation

timfish
Copy link
Collaborator

@timfish timfish commented Mar 25, 2024 •
edited

Backport of #11256

Scope wasn't working for the deprecated export (pre. integration) so I didn't spend any time trying to fix it and just don't test this scope feature for that.

@timfish
feat(node): Add scope to ANR events
f765d07 
improve comments

test isolated scope

minor

simplify test

longer other contexts
@timfish
fix build
037bf15
@timfish
Merge branch 'v7' into timfish/anr-scope-backport
5ff36e3
@timfish
Merge branch 'timfish/anr-scope-backport' of github.com:getsentry/sen…
389e947 
…try-javascript into timfish/anr-scope-backport
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 28, 2024 •
edited

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay, Feedback) - Webpack (gzipped) 80.48 KB (+0.01% 🔺)
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 71.47 KB (+0.01% 🔺)
@sentry/browser (incl. Tracing, Replay with Canvas) - Webpack (gzipped) 75.49 KB (+0.01% 🔺)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped) 65.11 KB (+0.01% 🔺)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 35.41 KB (+0.02% 🔺)
@sentry/browser (incl. browserTracingIntegration) - Webpack (gzipped) 35.29 KB (+0.01% 🔺)
@sentry/browser (incl. Feedback) - Webpack (gzipped) 31.52 KB (0%)
@sentry/browser (incl. sendFeedback) - Webpack (gzipped) 31.53 KB (0%)
@sentry/browser - Webpack (gzipped) 22.74 KB (0%)
@sentry/browser (incl. Tracing, Replay, Feedback) - ES6 CDN Bundle (gzipped) 78.59 KB (+0.01% 🔺)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 69.97 KB (0%)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 35.77 KB (+0.01% 🔺)
@sentry/browser - ES6 CDN Bundle (gzipped) 25.17 KB (0%)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 220.31 KB (+0.01% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 108.12 KB (+0.02% 🔺)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 75.48 KB (0%)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 39 KB (+0.01% 🔺)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 71.97 KB (+0.01% 🔺)
@sentry/react - Webpack (gzipped) 22.77 KB (0%)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 89.81 KB (+0.01% 🔺)
@sentry/nextjs Client - Webpack (gzipped) 53.95 KB (+0.01% 🔺)
@sentry-internal/feedback - Webpack (gzipped) 17.3 KB (0%)

@timfish timfish marked this pull request as ready for review March 28, 2024 17:48
@timfish timfish requested a review from AbhiPrasad March 28, 2024 17:50
@AbhiPrasad AbhiPrasad merged commit 9d680ff into v7 Mar 28, 2024
81 checks passed
@AbhiPrasad AbhiPrasad deleted the timfish/anr-scope-backport branch March 28, 2024 17:50
@AbhiPrasad AbhiPrasad mentioned this pull request Mar 28, 2024
Closed
@Lms24 Lms24 mentioned this pull request Apr 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AbhiPrasad AbhiPrasad AbhiPrasad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@timfish @AbhiPrasad