Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v8] HTTP client spans #11562

Closed
3 of 5 tasks
cleptric opened this issue Apr 11, 2024 · 2 comments
Closed
3 of 5 tasks

[v8] HTTP client spans #11562

cleptric opened this issue Apr 11, 2024 · 2 comments

Comments

@cleptric
Copy link
Member

cleptric commented Apr 11, 2024

Many users have been confused and frustrated by the fact that after the automatically created page load transaction is finished, XMLHttpRequest and fetch requests are only automatically instrumented with the user explicitly wrapping these requests in a transaction.

For v8, we want to change this by utilizing single-span ingestion. By default, each request will be traced and sent to Sentry as a segment span (span.isSegment: true,). The user can turn off the behaviour with a new Sentry.browserTracingIntegration() option.

@Lms24
Copy link
Member

Lms24 commented Apr 18, 2024

http.client spans count as segment spans and they need to have the following properties:

segmentId = spanId
isSegment: true

In contrast, INP spans don't need to set segment properties because we don't care about them not showing up in the trace view.

@Lms24
Copy link
Member

Lms24 commented May 23, 2024

Closing this at the moment as this is officially on hold until further notice. The experimental standalone option still exists but XHR and fetch request spans are still only created if there's a parent segment/root span. The PRs to send standalone fetch and XHR spans were reverted.

@Lms24 Lms24 closed this as completed May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants