fix(replay): Fix user activity not being updated in start()
#12001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note we do have tests for this situation for on error. |
mydea
reviewed
May 13, 2024
| // constructor, so if `start()` is called after | ||
| // session idle expiration, a replay will not be | ||
| // created due to an idle timeout. | ||
| this._updateUserActivity(); |
There was a problem hiding this comment.
🤯 ahhh I see, that makes sense of course!
mydea
approved these changes
May 13, 2024
andreiborza
pushed a commit
that referenced
this pull request
May 16, 2024
Replays will fail to start recording when using `start()` specifically when manually recording and after the user has been idle for a long period of time. We need to reset the user activity state when we call `start()`, otherwise the session will be [incorrectly] considered to be idle and unable to send any replay events. Closes #11983
This was referenced Jun 3, 2024
This was referenced Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replays will fail to start recording when using
start()specifically when manually recording and after the user has been idle for a long period of time. We need to reset the user activity state when we callstart(), otherwise the session will be [incorrectly] considered to be idle and unable to send any replay events.Closes #11983