Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a race condition in the electron SDK where we set the user on the scope but since we call the notifies in
setTimeout
the user is not properly propagated to the main process.So if you have this for example:
On electron, we sync the scope across different processes via IPC calls.
The previous code resulted in:
IPC -> captureException
IPC -> Scope update
after the change, because we are removing the
setTimeout
its:
IPC -> Scope update
IPC -> captureException