Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MySQL tracing does not support connection pools #3352

Closed
4 of 9 tasks
zchristopoulos opened this issue Mar 29, 2021 · 0 comments · Fixed by #3353
Closed
4 of 9 tasks

MySQL tracing does not support connection pools #3352

zchristopoulos opened this issue Mar 29, 2021 · 0 comments · Fixed by #3353

Comments

@zchristopoulos
Copy link
Contributor

Package + Version

  • @sentry/browser
  • @sentry/node
  • raven-js
  • raven-node (raven for node)
  • other:

Version:

6.2.3

Description

I have noticed that when a mysql query is ran via a connection pool, the tracing integration does not attach to the query. I looked through the source code of mysqljs and found that Pool.prototype.query directly calls Connection.createQuery and sends a fully structured Query object into Connection.prototype.query via the sql parameter. Because of this, the query is ignored by the tracing integration as the callback is not passed inside the standard values or callback parameters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant