Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document comparison between App Only vs. Full in React projects #3853

Closed
1 of 5 tasks
SevenOutman opened this issue Jul 30, 2021 · 7 comments
Closed
1 of 5 tasks

Document comparison between App Only vs. Full in React projects #3853

SevenOutman opened this issue Jul 30, 2021 · 7 comments

Comments

@SevenOutman
Copy link

Package + Version

  • @sentry/browser
  • @sentry/node
  • raven-js
  • raven-node (raven for node)
  • other:

Version:

6.8.0

Description

It's confusing when the "App Only" view is showing stack trace only from inside node_modules. Doesn't "App Only" mean "everything except within node_modules" for NPM projects?

image

Here's the "Full" view where the full stack trace is shown correctly.

image

@SevenOutman SevenOutman changed the title App Only vs. Full for React projects? DocumentApp Only vs. Full for React projects? Sep 1, 2021
@SevenOutman SevenOutman changed the title DocumentApp Only vs. Full for React projects? Document comparison between App Only vs. Full in React projects Sep 1, 2021
@kamilogorek
Copy link
Contributor

That is the correct assumption. The reason why it's not working as expected is that some webpack configuration variants are creating non-standard paths. Eg. in this case it's not webpack://./your/files which is standard we handle - https://github.com/getsentry/sentry/blob/master/src/sentry/lang/javascript/processor.py#L1023-L1024

As you can see in the code above, its not trivial to decide what is actually "in-app" when using webpack, as there are things like various node_modules paths, external, boostrap keywords etc.

To configure this properly, you need to use Stack Trace Rules in grouping settings of your project - https://docs.sentry.io/product/data-management-settings/event-grouping/stack-trace-rules/

In your case, it'll be something like that

stack.abs_path:webpack://devops-fe/./src/** +app

Hope that helps!

@SevenOutman
Copy link
Author

@kamilogorek Thanks for your explanation! But I can't find this Stack Trace setting in my Sentry instance. Is it available in v9 releases?

@kamilogorek
Copy link
Contributor

@SevenOutman grouping settings used to be a part of the project's General Settings, now they get it's own page. Maybe it can be found there?

@kamilogorek
Copy link
Contributor

This should be fixed soon - getsentry/sentry#28859

@SevenOutman
Copy link
Author

@SevenOutman grouping settings used to be a part of the project's General Settings, now they get it's own page. Maybe it can be found there?

No luck in my Sentry 9.1.2 installation :(

@Daniel15
Copy link

I can confirm that this is fixed in 21.10.0. Thanks @kamilogorek!

@kamilogorek
Copy link
Contributor

Thanks for getting back with the confirmation @Daniel15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants