feat(awslambda,captureAllSettledReasons) : Capture errors individually on sqs partial batch failure #4130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y on sqs partial batch failure A lambda can receive up to 1000 messages. (if we use a batchWindow), but it can fail because of 10/1000 messages failed. Tools such as [Middy](https://middy.js.org/) (and the `sqs-partial-batch-failure` plugin) allow managing this case by deleting records from the queue individually, so that we don't have to retry a record that has already worked. This PR suggests adding an option to capture all errors coming from a `Promise.allSettled`. The `wrapHandler` will not fail the lambda even if there are errors, because I assume that it will be the middy’s job.
AbhiPrasad
approved these changes
Nov 8, 2021
There was a problem hiding this comment.
Nice, thank you for your contribution! Mind also updating our docs to document captureAllSettledReasons? You can edit this page https://github.com/getsentry/sentry-docs/blob/master/src/platforms/node/guides/aws-lambda/index.mdx.
J4YF7O
pushed a commit
to J4YF7O/sentry-javascript
that referenced
this pull request
Dec 9, 2022
…context for each captured promises - Following getsentry#4130 # Description It can be very interesting to build a specific context depending on the error. And especially in my case, the index. This allows to find the corresponding SQSRecord, and to design tags from the body. This increases greatly the debugging capacity, and filtering at the sentry interface level.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting a pull request, please take a look at our
Contributing guidelines and verify:
yarn lint) & (yarn test).A lambda can receive up to 1000 messages. (if we use a batchWindow), but it can fail because of 10/1000 messages failed. Tools such as Middy (and the
sqs-partial-batch-failureplugin) allow managing this case by deleting records from the queue individually, so that we don't have to retry a record that has already worked.This PR suggests adding an option to capture all errors coming from a
Promise.allSettled. ThewrapHandlerwill not fail the lambda even if there are errors, because I assume that it will be the middy’s job.