feat(tracing): Add metadata around idleTimeout #4251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
AbhiPrasad
commented
Dec 8, 2021
AbhiPrasad
commented
- Add tag if user sets custom idleTimeout
- Add tag if user sets reportAllChanges option
- Add finish reason tag to idleTransactions (tracked in enum)
- Add tag if user sets custom idleTimeout - Add tag if user sets reportAllChanges option - Add finish reason tag to idleTransactions (tracked in enum)
AbhiPrasad
commented
Dec 8, 2021
|
|
||
| export const DEFAULT_METRICS_INSTR_OPTIONS: MetricsInstrumentationOptions = { | ||
| _reportAllChanges: false, | ||
| }; |
There was a problem hiding this comment.
Removed this logic to save on bundle size. We can add back in an options object when we have more than 1 option.
size-limit report
|
k-fish
approved these changes
Dec 8, 2021
onurtemizkan
pushed a commit
that referenced
this pull request
Dec 19, 2021
- Add tag if user sets custom idleTimeout - Add tag if user sets reportAllChanges option - Add finish reason tag to idleTransactions (tracked in enum)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.