ref(types): deprecate span status enum #4299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report
|
JonasBa
force-pushed
the
jb/bundle/drop-span-enum
branch
from
55031de
to
49f5c05
Compare
JonasBa
force-pushed
the
jb/bundle/drop-span-enum
branch
from
49f5c05
to
cc7beed
Compare
JonasBa
force-pushed
the
jb/bundle-drop-http
branch
from
37a1c24
to
3ccc3fe
Compare
JonasBa
force-pushed
the
jb/bundle/drop-span-enum
branch
2 times, most recently
from
49fbb5b
to
be554a9
Compare
|
@AbhiPrasad @mitsuhiko I think the size-limit report here is unstable. I ran the build locally between the two branches and there was 0 change to the browser bundle and about 300B change to bundle.tracing, which seems in line with size-limit. I'm not sure where the changes to browser build come from |
JonasBa
changed the title
JonasBa
force-pushed
the
jb/bundle/drop-span-enum
branch
from
be554a9
to
927dbb7
Compare
JonasBa
force-pushed
the
jb/bundle-drop-http
branch
from
718206d
to
cbae0d5
Compare
JonasBa
force-pushed
the
jb/bundle/drop-span-enum
branch
from
c986b1e
to
a725360
Compare
* ref(types): deprecate transactionmethod enum * fix(types): drop transactionsamplingmethod * ref(types): deprecate outcome enum (#4315) * ref(types): deprecate outcome enum * fix(types): drop transportoutcome * ref(types): deprecate request status enum (#4316) * ref(types): deprecate request status * ref(types): deprecate session status * ref(types): remove unused logLevel (#4317) (#4320)
AbhiPrasad
approved these changes
Dec 16, 2021
JonasBa
added a commit
that referenced
this pull request
Dec 16, 2021
* ref(types): deprecate enum and export type * ref(types): fix fromHttpCode usage to statusFromHttpCode * ref(types): remove enum usage * fix(types): fix mistake on span * fix: fmt * ref(types): do not export the status enum * ref(types): fix all imports * ref(utils): consistent naming * ref(types): deprecate span status enum (#4299) * ref(span): deprecate span status enum * ts(span): widen type * ref(span): avoid reexporting the enum * ref(types): fix all imports * fix(test): remove extra space * fix(test): import extension methods * ref(types): deprecate transactionmethod enum (#4314) * ref(types): deprecate transactionmethod enum * fix(types): drop transactionsamplingmethod * ref(types): deprecate outcome enum (#4315) * ref(types): deprecate outcome enum * fix(types): drop transportoutcome * ref(types): deprecate request status enum (#4316) * ref(types): deprecate request status * ref(types): deprecate session status * ref(types): remove unused logLevel (#4317) (#4320) Co-authored-by: Armin Ronacher <armin.ronacher@active-4.com>
JonasBa
added a commit
that referenced
this pull request
Dec 16, 2021
* fix(types): use SeverityLevel * fix(types): remove other references to the enum * fix(types): disable deprecation warning * fix(types): move fromString to utils * packages(types): fix exports * fix(rebase): fix conflicts * ref(types): deprecate status enum (#4298) * ref(types): deprecate enum and export type * ref(types): fix fromHttpCode usage to statusFromHttpCode * ref(types): remove enum usage * fix(types): fix mistake on span * fix: fmt * ref(types): do not export the status enum * ref(types): fix all imports * ref(utils): consistent naming * ref(types): deprecate span status enum (#4299) * ref(span): deprecate span status enum * ts(span): widen type * ref(span): avoid reexporting the enum * ref(types): fix all imports * fix(test): remove extra space * fix(test): import extension methods * ref(types): deprecate transactionmethod enum (#4314) * ref(types): deprecate transactionmethod enum * fix(types): drop transactionsamplingmethod * ref(types): deprecate outcome enum (#4315) * ref(types): deprecate outcome enum * fix(types): drop transportoutcome * ref(types): deprecate request status enum (#4316) * ref(types): deprecate request status * ref(types): deprecate session status * ref(types): remove unused logLevel (#4317) (#4320) Co-authored-by: Armin Ronacher <armin.ronacher@active-4.com> Co-authored-by: Armin Ronacher <armin.ronacher@active-4.com>
onurtemizkan
pushed a commit
that referenced
this pull request
Dec 19, 2021
* fix(types): use SeverityLevel * fix(types): remove other references to the enum * fix(types): disable deprecation warning * fix(types): move fromString to utils * packages(types): fix exports * fix(rebase): fix conflicts * ref(types): deprecate status enum (#4298) * ref(types): deprecate enum and export type * ref(types): fix fromHttpCode usage to statusFromHttpCode * ref(types): remove enum usage * fix(types): fix mistake on span * fix: fmt * ref(types): do not export the status enum * ref(types): fix all imports * ref(utils): consistent naming * ref(types): deprecate span status enum (#4299) * ref(span): deprecate span status enum * ts(span): widen type * ref(span): avoid reexporting the enum * ref(types): fix all imports * fix(test): remove extra space * fix(test): import extension methods * ref(types): deprecate transactionmethod enum (#4314) * ref(types): deprecate transactionmethod enum * fix(types): drop transactionsamplingmethod * ref(types): deprecate outcome enum (#4315) * ref(types): deprecate outcome enum * fix(types): drop transportoutcome * ref(types): deprecate request status enum (#4316) * ref(types): deprecate request status * ref(types): deprecate session status * ref(types): remove unused logLevel (#4317) (#4320) Co-authored-by: Armin Ronacher <armin.ronacher@active-4.com> Co-authored-by: Armin Ronacher <armin.ronacher@active-4.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.