Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(tracing): Add TTFB tests. #4424

Merged
merged 1 commit into from
Jan 20, 2022
Merged

Conversation

onurtemizkan
Copy link
Collaborator

Part of: #4262

Only checks the existence of measurement entries, as I could not find a way to emulate TTFB values like I've done with connection.rtt (#4423). Suggestions are welcome.

@github-actions
Copy link
Contributor

size-limit report

Path Base Size (eaf2e81) Current Size Change
@sentry/browser - CDN Bundle (gzipped) 19.59 KB 19.59 KB +0.02% 🔺
@sentry/browser - CDN Bundle (minified) 62.5 KB 62.5 KB +0.01% 🔺
@sentry/browser - Webpack 22.11 KB 22.11 KB 0%
@sentry/browser - Webpack - gzip = false 75.59 KB 75.59 KB 0%
@sentry/react - Webpack 22.14 KB 22.14 KB 0%
@sentry/nextjs Client - Webpack 46.33 KB 46.33 KB 0%
@sentry/browser + @sentry/tracing - CDN Bundle (gzipped) 28.3 KB 28.31 KB +0.02% 🔺

Copy link
Member

@AbhiPrasad AbhiPrasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine for now as a sanity check

@AbhiPrasad AbhiPrasad merged commit 3f2bf69 into master Jan 20, 2022
@AbhiPrasad AbhiPrasad deleted the onur/int-tests-vitals-ttfb branch January 20, 2022 15:10
@AbhiPrasad AbhiPrasad added this to the Release Stability milestone Feb 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants