Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(utils): Remove dom is casting #4451

Merged
merged 1 commit into from Jan 25, 2022
Merged

fix(utils): Remove dom is casting #4451

merged 1 commit into from Jan 25, 2022

Conversation

AbhiPrasad
Copy link
Member

Fixes #4449

Make sure we don't cast to Element or Event as these helpers can be used in node environments.

@AbhiPrasad AbhiPrasad enabled auto-merge (squash) January 25, 2022 15:25
@github-actions
Copy link
Contributor

size-limit report

Path Base Size (4edac41) Current Size Change
@sentry/browser - CDN Bundle (gzipped) 19.68 KB 19.68 KB +0.01% 🔺
@sentry/browser - CDN Bundle (minified) 62.85 KB 62.86 KB +0.01% 🔺
@sentry/browser - Webpack 22.2 KB 22.2 KB 0%
@sentry/browser - Webpack - gzip = false 75.99 KB 75.99 KB 0%
@sentry/react - Webpack 22.24 KB 22.24 KB 0%
@sentry/nextjs Client - Webpack 46.22 KB 46.22 KB 0%
@sentry/browser + @sentry/tracing - CDN Bundle (gzipped) 28.21 KB 28.22 KB +0.01% 🔺

@AbhiPrasad AbhiPrasad merged commit bf05736 into master Jan 25, 2022
@AbhiPrasad AbhiPrasad deleted the abhi-is-cast-event branch January 25, 2022 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot compile TS with @sentry/node without lib: DOM definitions present
2 participants