Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(build): Update and hoist rollup #4578

Merged
merged 2 commits into from
Feb 15, 2022
Merged

Conversation

lobsterkatie
Copy link
Member

As prep for the new bundling process, this updates rollup to latest and hoists it to the main package.json.

Other than single-character changes to generated variable names, the only effect this has on the generated bundles is to add Object.defineProperty(exports, '__esModule', { value: true }); (or its minified counterpart) at the end of each bundle. According to the Rollup docs:

This property signifies that the exported value is the namespace of an ES module and that the default export of this module corresponds to the .default property of the exported object.

Since we don't have default exports from our SDKs or integrations, this isn't necessary and just adds dead weight to the bundles. Setting output.esModule to false in the Rollup config prevents this addition.

@lobsterkatie lobsterkatie enabled auto-merge (squash) February 15, 2022 17:41
@github-actions
Copy link
Contributor

size-limit report

Path Base Size (0a6e535) Current Size Change
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 19.68 KB 19.68 KB +0.02% 🔺
@sentry/browser - ES5 CDN Bundle (minified) 63.17 KB 63.2 KB +0.04% 🔺
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 18.35 KB 18.35 KB +0.03% 🔺
@sentry/browser - ES6 CDN Bundle (minified) 56.35 KB 56.36 KB +0.04% 🔺
@sentry/browser - Webpack (gzipped + minified) 22.13 KB 22.13 KB 0%
@sentry/browser - Webpack (minified) 76.07 KB 76.07 KB 0%
@sentry/react - Webpack (gzipped + minified) 22.17 KB 22.17 KB 0%
@sentry/nextjs Client - Webpack (gzipped + minified) 46.31 KB 46.31 KB 0%
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 27.13 KB 27.14 KB +0.03% 🔺

@lobsterkatie lobsterkatie merged commit 4d77983 into master Feb 15, 2022
@lobsterkatie lobsterkatie deleted the kmclb-update-rollup-2.x branch February 15, 2022 17:52
@AbhiPrasad AbhiPrasad added this to the Pre 7.0.0 Work milestone Feb 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants