fix: bug.yml #4621
Merged
fix: bug.yml #4621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbhiPrasad
reviewed
Feb 23, 2022
| @@ -27,16 +27,16 @@ body: | |||
| attributes: | |||
| label: Which package are you using? | |||
| options: | |||
| - @sentry/angular | |||
There was a problem hiding this comment.
It can't compile yml when there is @ in front of it
There was a problem hiding this comment.
Then let’s add quotes to force it to become a string instead of making yaml coerce it?
There was a problem hiding this comment.
That actually works. Just tested it.
size-limit report
|
AbhiPrasad
approved these changes
Feb 23, 2022
| @@ -57,7 +57,7 @@ body: | |||
| id: link-to-sentry | |||
| attributes: | |||
| label: Link to Sentry event | |||
| description: If applicable, provide a link to the affected event from your Sentry account. The event will only be viewable by Sentry staff. **Note**: This should be an _event_ link, not an issue link, and should match the form shown below. It can be found by clicking on the event ID on the issue details page. | |||
| description: If applicable, provide a link to the affected event from your Sentry account. The event will only be viewable by Sentry staff. | |||
There was a problem hiding this comment.
Why remove this? (It's something even our staff get wrong without periodic reminders.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting a pull request, please take a look at our
Contributing guidelines and verify:
yarn lint) & (yarn test).