fix(build): Ensure full stacktraces when running rollup
#4833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbhiPrasad
approved these changes
Mar 31, 2022
An interesting idea. If we do, I think it should be part of a larger "monitor our CI with sentry" convo/project. (I actually needed this for my work locally, where it wouldn't have made any sense to report to Sentry, but having a record of the snags into which CI runs might not be a terrible thing.) |
lobsterkatie
deleted the
kmclb-ensure-full-stacktraces-during-rollup-build
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, node cuts stacktraces down to the final 10 frames. Sometimes, though, the stuff you're interested in is below that. This removes the cap for errors generated when running
rollup(which turned out to be necessary to diagnose a problem encountered during work on the new build process).