Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(dev): Run linter on scripts #4834

Merged
merged 4 commits into from
Mar 31, 2022
Merged

Conversation

lobsterkatie
Copy link
Member

@lobsterkatie lobsterkatie commented Mar 31, 2022

Because SDK developers running Windows can't run our bash scripts, we recently decided to move to using TypeScript instead. To make this easier, this extends the domain of our eslint and prettier checks to include all scripts folders. It also fixes a few linting errors which doing so brought to light.

Copy link
Member

@AbhiPrasad AbhiPrasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good change.

@lobsterkatie lobsterkatie enabled auto-merge (squash) March 31, 2022 23:21
@lobsterkatie lobsterkatie merged commit 5542518 into master Mar 31, 2022
@lobsterkatie lobsterkatie deleted the kmclb-run-linter-on-scripts branch March 31, 2022 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants