Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove stack parser support for Opera pre v15 #4923

Merged
merged 16 commits into from Apr 12, 2022

Conversation

timfish
Copy link
Collaborator

@timfish timfish commented Apr 12, 2022

Opera v15 was released in 2013 and was based on Chromium.

This PR removes the two Opera specific stack parsers that cater for versions before this from the defaults.

Anyone still wanting to support these ancient browser versions can do the following:

import { init, defaultStackParsers, opera10StackParser, opera11StackParser } from '@sentry/browser';

init({
  dsn: '__DSN__',
  stackParser: [...defaultStackParsers, opera10StackParser, opera11StackParser]
})

An alternative would be to just remove these parsers completely since I'm kinda doubting anyone is still using these browser....

AbhiPrasad and others added 16 commits April 7, 2022 13:32
Removes all references to `@sentry/apm`, a deprecated package we do not use anymore.
Removes the deprecated `API` class.
…ry#4849)

Remove deprecated methods `startSpan` and `child`.

These deprecated methods were removed in favour of `span.startChild`.
Removes `getActiveDomain` function and corresponding type.
The `user` dsn component was renamed to `publicKey`. This PR removes that from the dsn field.
Increases the creation timeout of `MongoMemoryServer` to temporarily fix Node integration test flakiness
This PR removes the previously deprecated `frameContextLines` from `NodeOptions`.
…4887)

These exports were historically used in `@sentry/electron`, but are no longer being used by the Electron SDK or the React Native SDK, so they can be removed.
@timfish timfish mentioned this pull request Apr 12, 2022
15 tasks
Copy link
Member

@AbhiPrasad AbhiPrasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can remove opera10StackParser and opera11StackParser in v8 :)

@AbhiPrasad AbhiPrasad merged commit 6445db2 into getsentry:7.x Apr 12, 2022
lobsterkatie pushed a commit that referenced this pull request Apr 13, 2022
Opera v15 was released in 2013 and was based on Chromium.

This PR removes the two Opera specific stack parsers that cater for versions before this from the defaults.

Anyone still wanting to support these ancient browser versions can do the following:

```ts
import { init, defaultStackParsers, opera10StackParser, opera11StackParser } from '@sentry/browser';

init({
  dsn: '__DSN__',
  stackParser: [...defaultStackParsers, opera10StackParser, opera11StackParser]
})
```
Lms24 pushed a commit that referenced this pull request Apr 26, 2022
Opera v15 was released in 2013 and was based on Chromium.

This PR removes the two Opera specific stack parsers that cater for versions before this from the defaults.

Anyone still wanting to support these ancient browser versions can do the following:

```ts
import { init, defaultStackParsers, opera10StackParser, opera11StackParser } from '@sentry/browser';

init({
  dsn: '__DSN__',
  stackParser: [...defaultStackParsers, opera10StackParser, opera11StackParser]
})
```
lobsterkatie pushed a commit that referenced this pull request Apr 26, 2022
Opera v15 was released in 2013 and was based on Chromium.

This PR removes the two Opera specific stack parsers that cater for versions before this from the defaults.

Anyone still wanting to support these ancient browser versions can do the following:

```ts
import { init, defaultStackParsers, opera10StackParser, opera11StackParser } from '@sentry/browser';

init({
  dsn: '__DSN__',
  stackParser: [...defaultStackParsers, opera10StackParser, opera11StackParser]
})
```
lobsterkatie pushed a commit that referenced this pull request Apr 26, 2022
Opera v15 was released in 2013 and was based on Chromium.

This PR removes the two Opera specific stack parsers that cater for versions before this from the defaults.

Anyone still wanting to support these ancient browser versions can do the following:

```ts
import { init, defaultStackParsers, opera10StackParser, opera11StackParser } from '@sentry/browser';

init({
  dsn: '__DSN__',
  stackParser: [...defaultStackParsers, opera10StackParser, opera11StackParser]
})
```
@timfish timfish deleted the v7/remove-pre-opera-v15-parsers branch May 19, 2022 19:26
AbhiPrasad pushed a commit that referenced this pull request May 30, 2022
Opera v15 was released in 2013 and was based on Chromium.

This PR removes the two Opera specific stack parsers that cater for versions before this from the defaults.

Anyone still wanting to support these ancient browser versions can do the following:

```ts
import { init, defaultStackParsers, opera10StackParser, opera11StackParser } from '@sentry/browser';

init({
  dsn: '__DSN__',
  stackParser: [...defaultStackParsers, opera10StackParser, opera11StackParser]
})
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants