feat(tracing): Add Prisma ORM integration. #4931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
|
@onurtemizkan can you please fix the lint error? |
Disabled the |
onurtemizkan
force-pushed
the
onur/prisma-orm-integration
branch
from
955211b
to
fdcad2a
Compare
onurtemizkan
force-pushed
the
onur/prisma-orm-integration
branch
from
06b41ed
to
65e9c8c
Compare
onurtemizkan
force-pushed
the
onur/prisma-orm-integration
branch
2 times, most recently
from
9f53c2d
to
fb6d61f
Compare
onurtemizkan
force-pushed
the
onur/prisma-orm-integration
branch
from
fb6d61f
to
a92f781
Compare
AbhiPrasad
reviewed
Apr 19, 2022
Co-authored-by: Abhijeet Prasad <aprasad@sentry.io>
AbhiPrasad
approved these changes
Apr 19, 2022
|
I think we can merge this in, @onurtemizkan mind also making some docs for this? |
|
@AbhiPrasad, Sure 👍 |
AbhiPrasad
reviewed
Apr 21, 2022
| NODE_MAJOR=$(node -v | cut -c2- | cut -d. -f1) | ||
|
|
||
| if [ "$NODE_MAJOR" -lt "12" ]; then | ||
| echo "Skipping Prisma tests on Node: $NODE_MAJOR" |
There was a problem hiding this comment.
I think going forward we would like everything to be node scripts. Can we convert this to a TS script (we have ts-node in the repo)?
AbhiPrasad
reviewed
Apr 21, 2022
| @@ -0,0 +1,22 @@ | |||
| { | |||
| "name": "sentry-prisma-test", | |||
There was a problem hiding this comment.
let's move this out into another PR so we can discuss the integration test separately? In the mean time, we can add sanity check unit tests to this PR (similar to what we have for mongo for ex.)
onurtemizkan
force-pushed
the
onur/prisma-orm-integration
branch
2 times, most recently
from
5258b74
to
575d843
Compare
AbhiPrasad
approved these changes
Apr 21, 2022
onurtemizkan
force-pushed
the
onur/prisma-orm-integration
branch
from
575d843
to
050d8dd
Compare
onurtemizkan
force-pushed
the
onur/prisma-orm-integration
branch
from
dc690d0
to
215beaf
Compare
Lms24
pushed a commit
that referenced
this pull request
Apr 26, 2022
Co-authored-by: Abhijeet Prasad <aprasad@sentry.io>
lobsterkatie
pushed a commit
that referenced
this pull request
Apr 26, 2022
Co-authored-by: Abhijeet Prasad <aprasad@sentry.io>
lobsterkatie
pushed a commit
that referenced
this pull request
Apr 26, 2022
Co-authored-by: Abhijeet Prasad <aprasad@sentry.io>
AbhiPrasad
added a commit
that referenced
this pull request
May 30, 2022
Co-authored-by: Abhijeet Prasad <aprasad@sentry.io>
|
Is it possible to add |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds Prisma ORM Tracing Integration.
This implementation is not auto-instrumented, as we seem to need the instance of
PrismaClientsupplied to us.Followed a similar approach with -> #3143 (comment) , using Prisma Client Middleware.
Resolves: #3143