Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tracing): Don't use querySelector when not available #5160

Merged
merged 1 commit into from May 24, 2022
Merged

fix(tracing): Don't use querySelector when not available #5160

merged 1 commit into from May 24, 2022

Conversation

lforst
Copy link
Member

@lforst lforst commented May 24, 2022

Fixes #4098

@lforst lforst requested review from Lms24 and lobsterkatie May 24, 2022 12:54
@lforst
Copy link
Member Author

lforst commented May 24, 2022

We really need to find a safer type definition for getGlobalObject...

Lms24
Lms24 approved these changes May 24, 2022
View reviewed changes
Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 19.32 KB (-4.06% 🔽)
@sentry/browser - ES5 CDN Bundle (minified) 59.9 KB (-7.3% 🔽)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 18.18 KB (-3.63% 🔽)
@sentry/browser - ES6 CDN Bundle (minified) 53.58 KB (-7.57% 🔽)
@sentry/browser - Webpack (gzipped + minified) 19.87 KB (-14.49% 🔽)
@sentry/browser - Webpack (minified) 63.03 KB (-22.87% 🔽)
@sentry/react - Webpack (gzipped + minified) 19.89 KB (-14.53% 🔽)
@sentry/nextjs Client - Webpack (gzipped + minified) 43.72 KB (-9.03% 🔽)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 25.34 KB (-2.81% 🔽)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 23.9 KB (-2.4% 🔽)

@lforst lforst merged commit fa5712e into 7.x May 24, 2022
@lforst lforst deleted the lforst-fix-queryselector-not-available branch May 24, 2022 13:21
AbhiPrasad pushed a commit that referenced this pull request May 30, 2022
@lforst @AbhiPrasad
fix(tracing): Don't use querySelector when not available (#5160)
9abca91
@AbhiPrasad AbhiPrasad added this to the 7.0.0 milestone May 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lms24 Lms24 Lms24 approved these changes

@lobsterkatie lobsterkatie Awaiting requested review from lobsterkatie

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
7.0.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lforst @Lms24 @AbhiPrasad