Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(node): Compression support for http transport #5209

Merged
merged 2 commits into from Jun 7, 2022

Conversation

lobsterkatie
Copy link
Member

@lobsterkatie lobsterkatie commented Jun 4, 2022

Note: This is an exact duplicate of #5139 and #5203, both originally by @timfish, which accidentally got merged into the 7.x branch rather than master.

#5139:

This is mostly stolen straight from the Electron transport.

This will help with attachments!

#5203:

#5139 introduced a subtle bug where options.headers was modified which causes headers to leak between requests. This means requests after a compressed request will be incorrectly marked with content-encoding: gzip.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 4, 2022

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 19.43 KB (-3.54% 🔽)
@sentry/browser - ES5 CDN Bundle (minified) 60.2 KB (-6.83% 🔽)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 18.23 KB (-3.33% 🔽)
@sentry/browser - ES6 CDN Bundle (minified) 53.82 KB (-7.15% 🔽)
@sentry/browser - Webpack (gzipped + minified) 19.99 KB (-13.96% 🔽)
@sentry/browser - Webpack (minified) 65.19 KB (-20.22% 🔽)
@sentry/react - Webpack (gzipped + minified) 20.02 KB (-14.01% 🔽)
@sentry/nextjs Client - Webpack (gzipped + minified) 43.76 KB (-8.93% 🔽)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 25.46 KB (-2.38% 🔽)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 23.98 KB (-2.05% 🔽)

@lobsterkatie lobsterkatie merged commit 5791c49 into master Jun 7, 2022
@lobsterkatie lobsterkatie deleted the kmclb-move-5139-to-master branch June 7, 2022 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants