Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tracePropagationTargets to Node #5403

Closed
smeubank opened this issue Jul 11, 2022 · 0 comments · Fixed by #5521
Closed

Add tracePropagationTargets to Node #5403

smeubank opened this issue Jul 11, 2022 · 0 comments · Fixed by #5521
Assignees

Comments

@smeubank
Copy link
Member

smeubank commented Jul 11, 2022

Problem statement:

There is currently no way for Node developers to control to which outgoing requests tracing headers are propagated.

Why is this a problem?

  • Currently, the Node SDK will send DSC to any outgoing requests including potential PII
  • There is currently no config available to block sending information to 3rd parties
  • It is also an issue when 3rd parties also use Sentry - Stripe example - and they will treat it as their DSC and can negatively influence DS decisions

How does it work in the Browser SDK?

  • tracingOrigins is an array of domains where we can send tracing headers for outgoing requests
  • On a request, if the request-target matches an item from the array, it will create a span and add tracing
  • A suggestion:
    • separate these 2 (span and instrumenting)
    • that would be a non-breaking change

How to fix?

Currently, we have the tracingOrigins option implemented in the JS browser SDK, and some other SDKs like Java and Android. It has been agreed that another option (tracePropagationTargets) will be included as part of standard features for all Sentry SDK(s). The tracePropagationTargets should also at some point supersede the deprecated tracingOrigins in the Browser SDK.

The desired behavior of tracePropagationTargets in the Node SDK:

  • By default, all outgoing requests are instrumented with trace data.
  • If a tracePropagationTargets option is provided by the user, only requests with URLs that match an item in the array will have trace data attached.

Further information:

@smeubank smeubank changed the title tracingOrigins (tbc) add to Node tracePropagationTargets add to Node Jul 11, 2022
@smeubank smeubank added this to the Dynamic Sampling Context milestone Aug 1, 2022
@lforst lforst self-assigned this Aug 2, 2022
@lforst lforst changed the title tracePropagationTargets add to Node Add tracePropagationTargets to Node Aug 2, 2022
@lforst lforst changed the title Add tracePropagationTargets to Node Add tracePropagationTargets to Node Aug 2, 2022
@lforst lforst changed the title Add tracePropagationTargets to Node Add tracePropagationTargets to Node Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants