Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(remix): Do not capture 4xx codes from thrown responses. #5441

Merged
merged 1 commit into from Jul 21, 2022
Merged

fix(remix): Do not capture 4xx codes from thrown responses. #5441

merged 1 commit into from Jul 21, 2022

Conversation

onurtemizkan
Copy link
Collaborator

@onurtemizkan onurtemizkan commented Jul 21, 2022 •
edited

Fixes: #5425

Ref: #5429, #5405

As per review #5429 (comment), we need to define how and when we should capture a 4xx error.

We will only capture thrown 5xx responses until then.

@onurtemizkan onurtemizkan added this to the Sentry Remix SDK milestone Jul 21, 2022
@onurtemizkan onurtemizkan self-assigned this Jul 21, 2022
lobsterkatie
lobsterkatie approved these changes Jul 21, 2022
View reviewed changes
Copy link
Member

@lobsterkatie lobsterkatie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lobsterkatie lobsterkatie merged commit 25c3dc7 into master Jul 21, 2022
@lobsterkatie lobsterkatie deleted the onur/remix-avoid-catching-4xx branch July 21, 2022 18:53
@alexblack
Copy link

Great to see this merged! Do you know when it might get released?

@eltonchan
Copy link

image
I also encountered the same problem, it seems that it should be the same root cause

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lobsterkatie lobsterkatie lobsterkatie approved these changes

Assignees

@onurtemizkan onurtemizkan

Labels
Package: remix
Projects
None yet
Milestone
Sentry Remix SDK
Development

Successfully merging this pull request may close these issues.

Object.captureException
4 participants
@onurtemizkan @alexblack @eltonchan @lobsterkatie