fix(nextjs): Stop using eval when checking for sentry-cli binary

[lobsterkatie]

In #4988, we switched to using eval in ensureCLIBinaryExists (called by our build-time config code in the nextjs SDK), in order to prevent Vercel's dependency-tracing algorithm from thinking the binary was a (n enormous) dependency and including it in people's serverless functions. (It was getting tricked by the require.resolve() call; turning that call into a string was the only way we could find to hide it from the algorithm.)

But eval is kind of gross. And Rollup, which agrees it's gross, keeps yelling at us for using it. In order to suppress the warnings and generally clean things up, this replaces the eval with real code again, and in that real code replaces the require.resolve() call with a manual check of all of the paths require.resolve() would consider. No require means no confused algorithm means no erroneously bundled cli binary in Vercel. And no eval means happy Rollup means happy us, because now it's easier to see when the build has legit errors. Wins all around.

[Lms24]

Wins all around

I couldn't agree more! 🚀