fix(integration): Don't mangle localforage internals

[lforst]

The localforage library (used in offline integration) has some internal fields with a leading underscore (e.g. _initStorage). In our building process, we allow terser to mangle fields with a leading underscore to reduce bundle size when using classes with private fields. This causes internal breakage within the localforage package and throwing a "Error: Custom driver not compliant" error.

This PR marks some localforage-internal fields as reserved so they don't get mangled. The fields are taken from the localforage docs by searching the page for "_".

Fixes #5527

[Lms24]

Nice fix! I wonder if there's any possibility to mark these field names as reserved only in the localforage "context" (if that makes sense)? But then again, I've never come across these field names in our project so I guess it's not a big issue(?)

[lforst]

I wonder if there's any possibility to mark these field names as reserved only in the localforage "context" (if that makes sense)?

@Lms24 Yeah I thought about the same thing. I looked in the terser settings if there is some way to apply mangling settings to some isolated context but I don't think there is. :(

Merging this but hopefully, we can get rid of classes in the SDK so we don't need to mangle private fields at all anymore.

[Lms24]

Yeah, I think it's totally fine for the time being!

we can get rid of classes in the SDK

A dev can always dream ;)

[lobsterkatie]

If we're going to get rid of anything, it's our localforage dependency. It's given us almost nothing but grief from the time we added it, and all it does is wrap native APIs. Someday, when we have time...