Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tracing): Set sample rate in transaction metadata and DSC #5691

Merged
merged 2 commits into from Sep 2, 2022

Conversation

Lms24
Copy link
Member

@Lms24 Lms24 commented Sep 2, 2022

Set the transaction.metadata.transactionSampling.rate field to 1 or 0 depending on transaction.sampled (if it is defined)

Fixes #5690

@github-actions
Copy link
Contributor

github-actions bot commented Sep 2, 2022

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 19.42 KB (+0.01% 🔺)
@sentry/browser - ES5 CDN Bundle (minified) 60.08 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 17.99 KB (+0.01% 🔺)
@sentry/browser - ES6 CDN Bundle (minified) 52.94 KB (0%)
@sentry/browser - Webpack (gzipped + minified) 19.79 KB (0%)
@sentry/browser - Webpack (minified) 64.33 KB (0%)
@sentry/react - Webpack (gzipped + minified) 19.81 KB (0%)
@sentry/nextjs Client - Webpack (gzipped + minified) 44.67 KB (+0.01% 🔺)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 25.92 KB (+0.03% 🔺)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 24.29 KB (+0.03% 🔺)

@Lms24 Lms24 merged commit f13fed6 into master Sep 2, 2022
@Lms24 Lms24 deleted the lms-fix-sample-rate-explicitly-set branch September 2, 2022 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DSC: sample_rate is not set when sample decision is forced
2 participants