Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref(tracing): Add propagations to tracing SDK #5719

Merged
merged 1 commit into from Sep 13, 2022
Merged

ref(tracing): Add propagations to tracing SDK #5719

merged 1 commit into from Sep 13, 2022

Conversation

AbhiPrasad
Copy link
Member

Part of #5679

Dependent on #5714 merging

This PR updates the propagations metadata field in the tracing SDK for BrowserTracing. It does this by adding a propagations incrementor to the fetch and XHR instrumentation.

@AbhiPrasad AbhiPrasad self-assigned this Sep 12, 2022
@AbhiPrasad AbhiPrasad added this to the Dynamic Sampling milestone Sep 12, 2022
@AbhiPrasad AbhiPrasad mentioned this pull request Sep 12, 2022
Closed
10 tasks
@github-actions
Copy link
Contributor

github-actions bot commented Sep 12, 2022 •
edited

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 19.46 KB (+0.01% 🔺)
@sentry/browser - ES5 CDN Bundle (minified) 60.11 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 18.04 KB (+0.01% 🔺)
@sentry/browser - ES6 CDN Bundle (minified) 53.03 KB (0%)
@sentry/browser - Webpack (gzipped + minified) 19.83 KB (0%)
@sentry/browser - Webpack (minified) 64.42 KB (0%)
@sentry/react - Webpack (gzipped + minified) 19.85 KB (0%)
@sentry/nextjs Client - Webpack (gzipped + minified) 44.91 KB (+0.07% 🔺)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 26.03 KB (+0.09% 🔺)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 24.42 KB (+0.09% 🔺)

lforst
lforst approved these changes Sep 12, 2022
View reviewed changes
Copy link
Member

@lforst lforst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean!

Base automatically changed from abhi-transaction-name-change-interface to master September 12, 2022 13:10
@AbhiPrasad AbhiPrasad merged commit 60b394a into master Sep 13, 2022
@AbhiPrasad AbhiPrasad deleted the abhi-browser-sdk-propagations branch September 13, 2022 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lforst lforst lforst approved these changes

Assignees

@lforst lforst

@AbhiPrasad AbhiPrasad

Labels
None yet
Projects
None yet
Milestone
Dynamic Sampling
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@AbhiPrasad @lforst