Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove withSentry in sentry-nextjs package #5893

Closed
vladanpaunovic opened this issue Oct 5, 2022 · 2 comments
Closed

Remove withSentry in sentry-nextjs package #5893

vladanpaunovic opened this issue Oct 5, 2022 · 2 comments
Labels
Meta: Breaking Package: nextjs Issues related to the Sentry Nextjs SDK Type: Improvement
Milestone
8.0.0

Comments

@vladanpaunovic
Copy link
Contributor

vladanpaunovic commented Oct 5, 2022 •
edited

Problem Statement

As per #5778 we are doing all route wrapping on our own and having withSentry function has a potential to cause confusion and frankly, it becomes a tech debt the moment we promote auto wrapping of nexjs API routes to default SDK behaviour.

Solution Brainstorm

⚠️ this is a breaking change. I propose we schedule this for our v8 release ⚠️

  1. Remove the withSentry from sentry-nextjs package
  2. Communicate breaking changes in v8 of the SDK.
@vladanpaunovic vladanpaunovic added Type: Improvement Package: nextjs Issues related to the Sentry Nextjs SDK labels Oct 5, 2022
@vladanpaunovic vladanpaunovic added this to the 8.0.0 milestone Oct 5, 2022
@lobsterkatie
Copy link
Member

Yup, this is the plan.

@AbhiPrasad
Copy link
Member

Done with #10549

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Meta: Breaking Package: nextjs Issues related to the Sentry Nextjs SDK Type: Improvement
Projects
None yet
Milestone
8.0.0
Development

No branches or pull requests
4 participants
@lobsterkatie @AbhiPrasad @hubertdeng123 @vladanpaunovic