Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dangerous const to var rollup plugin #5925

Closed
lforst opened this issue Oct 11, 2022 · 0 comments · Fixed by #5970
Closed

Dangerous const to var rollup plugin #5925

lforst opened this issue Oct 11, 2022 · 0 comments · Fixed by #5970

Comments

@lforst
Copy link
Member

lforst commented Oct 11, 2022

#5917 revealed something we didn't fully consider when writing our const to var rollup plugin. This plugin is supposed to reduce bundle size but it also has a semantic impact that can lead to opaque bugs.

We should definitely reconsider if we want to keep this plugin, or if we should at least change it to a "const to let" plugin.

Plugin in question:

export function makeConstToVarPlugin() {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant