Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bower install is unusable without resolve tracekit dependency by hand #61

Closed
iknite opened this issue Jan 28, 2013 · 4 comments
Closed

Comments

@iknite
Copy link
Contributor

iknite commented Jan 28, 2013

Hi!

I've just pump to v1.0.0 and notice it's no longer tracekit inside your repo, because bower don't follow cloning the submodule.

For now installing tracekit as component bower install tracekit gets the job done, but maybe creating a folder build/ with the minified version with the tracekit could be a way to go. I'll prefer not to download by hand your handy version in the CDN, and keep bower handle my project dependencies.

Probably it's more an bower issue, than yours, but's just to let you know.

fast track to this issue:

cd /tmp && mkdir tracekit-bug && cd tracekit-bug #just to use a clean folder
bower install raven-js
ls components/raven-js/vendor/TraceKit/ #nothing here :(

impressive project BTW!

Cheers,
iknite

@mattrobenolt
Copy link
Contributor

@iknite I'll look into bower today and see if the issue can be resolved on their end.

If anything, I'd rather completely vendorize TraceKit rather than maintain builds inside of a build/ directory, but that's just me. :)

@iknite
Copy link
Contributor Author

iknite commented Jan 28, 2013

Maybe configuring the dependencies in your component.json could be just what I need (I've just thought about that)

I can play with that a little and check if it works

@mattrobenolt
Copy link
Contributor

@iknite, at this point, you know more than I do about bower, so feel free. I'll be checking into it later in the day and try to hunt down the actual issue. A submodule should work, in my opinion.

@mattrobenolt
Copy link
Contributor

Fixed with d4da53e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants