feat(utils): Improved envelope parser #6580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timfish
changed the title
lforst
approved these changes
Dec 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An envelope parser has existed in
packages/utils/test/testutils.tsfor a while. It looks like this was originally copied from the Electron e2e test server. I wrote that code and it's pretty awful and was only ever intended to be used for testing.To offer the best support for Replay (getsentry/sentry-electron#606), its looking like the Electron main process will need to parse, modify and relay envelopes from the renderer processes. Sending events from renderer to main via a transport rather than an integration also fixes issues with integration ordering and confusing messages logged about events being dropped due to event processors returns null.
The new
parseEnvelopehas moved to@sentry/utilswhere it can be used by downstream SDKs.parseEnvelopeis tested as before by round-tripping withserializeEnvelope.