fix(replay): Allow Replay to be used in Electron renderers with nodeIntegration enabled #6644
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6630
In Electron renderers with
nodeIntegration
enabled,process.type === 'renderer'
.I think this should be ok with bundlers. I think the check below for
isNodeEnv
usesObject.prototype.toString
because bundlers can shim process with an object:sentry-javascript/packages/utils/src/node.ts
Lines 13 to 20 in 371d42d