fix(nextjs): Don't write to res.end
to fix next export
#6682
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6088
When running
next export
when having a custom_error
page and a custom404
page, Next.js will call the_error
'sgetInitialProps
. In this call, a specialres
object seems to be passed that doesn't have a.end()
method.This PR fixes a bug where we're trying to access that
.end
property even though it doesn't exist by simply checking for it first. Since exporting will create static pages we don't need to patch.end
anyways.