Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(otel): Prevent baggage from being overwritten #6709

Merged
merged 3 commits into from Jan 11, 2023
Merged

Conversation

AbhiPrasad
Copy link
Member

@AbhiPrasad AbhiPrasad commented Jan 10, 2023

ref: #6713

We want to make sure that existing baggage is not overwritten when the Sentry Propagator sets the baggage header on the carrier. To do this, we defer to using the W3CBaggagePropagator to set the baggage header, and add the Sentry values by setting baggage via OpenTelemetry's baggage API.

@AbhiPrasad AbhiPrasad added this to the OpenTelemetry Support milestone Jan 10, 2023
@AbhiPrasad AbhiPrasad self-assigned this Jan 10, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jan 10, 2023

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 19.84 KB (-0.01% 🔽)
@sentry/browser - ES5 CDN Bundle (minified) 61.46 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 18.62 KB (+0.02% 🔺)
@sentry/browser - ES6 CDN Bundle (minified) 55 KB (0%)
@sentry/browser - Webpack (gzipped + minified) 20.38 KB (0%)
@sentry/browser - Webpack (minified) 66.55 KB (0%)
@sentry/react - Webpack (gzipped + minified) 20.4 KB (0%)
@sentry/nextjs Client - Webpack (gzipped + minified) 47.63 KB (0%)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 26.82 KB (+0.02% 🔺)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 25.25 KB (-0.01% 🔽)
@sentry/replay ES6 CDN Bundle (gzipped + minified) 43.04 KB (+0.01% 🔺)
@sentry/replay - Webpack (gzipped + minified) 38.25 KB (-0.01% 🔽)

@AbhiPrasad AbhiPrasad force-pushed the abhi-propagator branch 2 times, most recently from 60186b3 to 99401ea Compare January 11, 2023 13:12
@AbhiPrasad AbhiPrasad marked this pull request as ready for review January 11, 2023 13:20
@AbhiPrasad AbhiPrasad enabled auto-merge (squash) January 11, 2023 13:20
@AbhiPrasad AbhiPrasad merged commit 6fe893d into master Jan 11, 2023
@AbhiPrasad AbhiPrasad deleted the abhi-propagator branch January 11, 2023 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants