Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(remix): Make remix SDK type exports isomorphic #6715

Merged
merged 5 commits into from Jan 10, 2023

Conversation

lforst
Copy link
Member

@lforst lforst commented Jan 10, 2023

Fixes #6705

This PR makes the Remix SDK typings isomorphic by creating a type-only entrypoint that exports everything from the client part of the SDK and everything from the server part of the SDK.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 10, 2023

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 19.84 KB (-0.01% 🔽)
@sentry/browser - ES5 CDN Bundle (minified) 61.46 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 18.62 KB (+0.01% 🔺)
@sentry/browser - ES6 CDN Bundle (minified) 55 KB (0%)
@sentry/browser - Webpack (gzipped + minified) 20.38 KB (0%)
@sentry/browser - Webpack (minified) 66.55 KB (0%)
@sentry/react - Webpack (gzipped + minified) 20.4 KB (-0.01% 🔽)
@sentry/nextjs Client - Webpack (gzipped + minified) 47.63 KB (-0.01% 🔽)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 26.82 KB (+0.02% 🔺)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 25.25 KB (-0.01% 🔽)
@sentry/replay ES6 CDN Bundle (gzipped + minified) 43.05 KB (-0.01% 🔽)
@sentry/replay - Webpack (gzipped + minified) 38.3 KB (0%)

Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just checking, no action required: Do we not need to restructure things here like in NextJS?

@lforst
Copy link
Member Author

lforst commented Jan 10, 2023

just checking, no action required: Do we not need to restructure things here like in NextJS?

Not required but we definitely should in the future! The reason I restructured things in the Next.js SDK was as preparation for app directory and edge runtime changes.

@lforst lforst merged commit 9bd6296 into master Jan 10, 2023
@lforst lforst deleted the lforst-fix-remix-types branch January 10, 2023 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Module '"@sentry/remix"' has no exported member 'Replay'
2 participants