Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(nextjs): Add optional options argument to withSentryConfig as an alternative to the sentry property #6721

Merged
merged 6 commits into from Jan 12, 2023
Merged

feat(nextjs): Add optional options argument to withSentryConfig as an alternative to the sentry property #6721

merged 6 commits into from Jan 12, 2023

Conversation

roggenkemper
Copy link
Member

This pr adds a new optional argument for withSentryConfig that allows for easier merging of the next.config.js files in the Sentry Wizard. Now, the Wizard will call withSentryConfig with the 3rd argument which adds in the Sentry options we want to add to the config. This allows for easier merging of the config files, as 2 lines can be added to the existing next.config.js for it to work (getsentry/sentry-wizard#222)

@roggenkemper roggenkemper mentioned this pull request Jan 10, 2023
Merged
@github-actions
Copy link
Contributor

github-actions bot commented Jan 10, 2023 •
edited

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 19.84 KB (0%)
@sentry/browser - ES5 CDN Bundle (minified) 61.46 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 18.62 KB (+0.02% 🔺)
@sentry/browser - ES6 CDN Bundle (minified) 55 KB (0%)
@sentry/browser - Webpack (gzipped + minified) 20.38 KB (0%)
@sentry/browser - Webpack (minified) 66.55 KB (0%)
@sentry/react - Webpack (gzipped + minified) 20.4 KB (0%)
@sentry/nextjs Client - Webpack (gzipped + minified) 47.63 KB (0%)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 26.82 KB (+0.02% 🔺)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 25.25 KB (-0.01% 🔽)
@sentry/replay ES6 CDN Bundle (gzipped + minified) 43.04 KB (+0.01% 🔺)
@sentry/replay - Webpack (gzipped + minified) 38.25 KB (0%)

@roggenkemper roggenkemper marked this pull request as ready for review January 10, 2023 22:05
scefali
scefali approved these changes Jan 10, 2023
View reviewed changes
Copy link
Member

@scefali scefali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but let's ask @lforst what he thinks

@lforst lforst changed the title feat(nextjs): adds optional argument for withSentryConfig for Sentry Wizard merging of next.config.js feat(nextjs): Add optional argument for withSentryConfig for Sentry Wizard merging of next.config.js Jan 11, 2023
@lforst lforst changed the title feat(nextjs): Add optional argument for withSentryConfig for Sentry Wizard merging of next.config.js feat(nextjs): Add optional options argument to withSentryConfig as an alternative to the sentry property Jan 11, 2023
@lforst lforst merged commit 9e3390d into master Jan 12, 2023
@lforst lforst deleted the roggenkemper/withsentryconfigarg branch January 12, 2023 15:43
@lforst
Copy link
Member

lforst commented Jan 12, 2023

This is probably gonna go out with a release on Monday

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lforst lforst lforst approved these changes

@scefali scefali scefali approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@roggenkemper @lforst @scefali