fix(replay): Fix incorrect uncompressed recording size due to encoding #6740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
billyvg
force-pushed
the
fix-replay-fix-recording-size-uncompressed
branch
from
1a9a5a7
to
bd1bb06
Compare
mydea
reviewed
Jan 12, 2023
| @@ -17,6 +18,10 @@ useFakeTimers(); | |||
| let replay: ReplayContainer; | |||
|
|
|||
| describe('Integration | coreHandlers | handleGlobalEvent', () => { | |||
| beforeAll(() => { | |||
| (global as any).TextEncoder = TextEncoder; | |||
There was a problem hiding this comment.
Could we move this into jest.setup.ts or similar? Just an idea?
|
Does this include the |
billyvg
force-pushed
the
fix-replay-fix-recording-size-uncompressed
branch
from
bd1bb06
to
ce59300
Compare
Lms24
approved these changes
Jan 12, 2023
| @@ -17,6 +18,10 @@ useFakeTimers(); | |||
| let replay: ReplayContainer; | |||
|
|
|||
| describe('Integration | coreHandlers | handleGlobalEvent', () => { | |||
| beforeAll(() => { | |||
| (global as any).TextEncoder = TextEncoder; | |||
mydea
approved these changes
Jan 16, 2023
For uncompressed payloads, we were potentially sending the incorrect size due to encoding issues. Instead encode to UTF8 when determining the payload size. Note that `TextEncoder` mostly overlaps with `MutationObserver` support *except* for IE11. So we will not be supporting IE11.
This reverts commit 7157ef2.
mydea
force-pushed
the
fix-replay-fix-recording-size-uncompressed
branch
from
40e3e06
to
129820f
Compare
|
I will go ahead and merge this so we get this into todays release! |
mydea
changed the title
mydea
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For uncompressed payloads, we were potentially sending the incorrect size due to encoding issues. Instead encode to UTF8 when determining the payload size. Note that
TextEncodermostly overlaps withMutationObserversupport except for IE11. So we will not be supporting IE11.