fix(tracing): Attach request instrumentation span to active span instead of current transaction #6778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ead of current transaction
size-limit report 📦
|
AbhiPrasad
approved these changes
Jan 16, 2023
Comment on lines
190
to
192
| const currentScope = getCurrentHub().getScope(); | ||
| const currentSpan = currentScope ? currentScope.getSpan() : undefined; | ||
| const activeTransaction = currentSpan ? currentSpan.transaction : undefined; |
There was a problem hiding this comment.
Suggested change
| const currentScope = getCurrentHub().getScope(); | |
| const currentSpan = currentScope ? currentScope.getSpan() : undefined; | |
| const activeTransaction = currentSpan ? currentSpan.transaction : undefined; | |
| const currentScope = getCurrentHub().getScope(); | |
| const currentSpan = currentScope && currentScope.getSpan(); | |
| const activeTransaction = currentSpan && currentSpan.transaction; |
Ditto with the logic below.
…st-spans-to-current-span
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the request instrumentation (fetch & XHR) doesn't attach spans to the currently active span on the scope but always on the active transaction.
While trying to instrument fetch for wintercg runtimes I ran into the issue that even when we intentionally set the span on the scope, fetch spans would still end up on the transaction. This PR would fix this behavior by attaching the fetch/xhr span to the currently active span instead.