fix(nextjs): Export isomorphic data fetching wrappers from client SDK #6790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbhiPrasad
added a commit
that referenced
this pull request
Jan 16, 2023
AbhiPrasad
approved these changes
Jan 16, 2023
| type AppGetInitialProps = typeof App['getInitialProps']; | ||
|
|
||
| /** | ||
| * A passthrough function in case this function is used on the clientside. We need to make the returned function async |
There was a problem hiding this comment.
could we theoretically create spans instead of transactions here?
There was a problem hiding this comment.
Yeah we definitely could in the future!
…de-data-fetcher-export
size-limit report 📦
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes some issue I can't find anymore where when our wrappers are used manually on isomorphic data fetchers (
getInitialProps), they throw an error.We're fixing this by exporting pass-through wrappers from the client SDK. The typing file was also updated so the server and client SDK types don't collide.